Clarify that TransportService#sendRequest never throws #89298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not obvious from reading the code that `TransportService#sendRequest` and friends always catch exceptions and pass them to the response handler, which means some callers are wrapping calls to `sendRequest` in their own unnecessary try/catch blocks. This commit makes it clear that all exceptions are handled and removes the unnecessary exception handling in callers. Closes elastic#89274
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not obvious from reading the code that
TransportService#sendRequestand friends always catch exceptions andpass them to the response handler, which means some callers are wrapping
calls to
sendRequestin their own unnecessary try/catch blocks. Thiscommit makes it clear that all exceptions are handled and removes the
unnecessary exception handling in callers.
Closes #89274