-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop transport client from ping_schedule docs #89264
Merged
DaveCTurner
merged 1 commit into
elastic:main
from
DaveCTurner:2022-08-11-ping-schedule-docs
Aug 11, 2022
Merged
Drop transport client from ping_schedule docs #89264
DaveCTurner
merged 1 commit into
elastic:main
from
DaveCTurner:2022-08-11-ping-schedule-docs
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for `transport.ping_schedule` note that the transport client defaults to a 5s ping schedule, but this is no longer relevant. This commit drops this from the docs, and also moves the docs for this setting further down the page to reflect its relative unimportance.
DaveCTurner
added
>docs
General docs changes
:Distributed Coordination/Network
Http and internode communication implementations
v8.3.4
v8.4.1
v8.5.0
labels
Aug 11, 2022
elasticsearchmachine
added
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
labels
Aug 11, 2022
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 11, 2022
The docs for `transport.ping_schedule` note that the transport client defaults to a 5s ping schedule, but this is no longer relevant. This commit drops this from the docs, and also moves the docs for this setting further down the page to reflect its relative unimportance.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 11, 2022
The docs for `transport.ping_schedule` note that the transport client defaults to a 5s ping schedule, but this is no longer relevant. This commit drops this from the docs, and also moves the docs for this setting further down the page to reflect its relative unimportance.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2022
The docs for `transport.ping_schedule` note that the transport client defaults to a 5s ping schedule, but this is no longer relevant. This commit drops this from the docs, and also moves the docs for this setting further down the page to reflect its relative unimportance.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2022
The docs for `transport.ping_schedule` note that the transport client defaults to a 5s ping schedule, but this is no longer relevant. This commit drops this from the docs, and also moves the docs for this setting further down the page to reflect its relative unimportance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Network
Http and internode communication implementations
>docs
General docs changes
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
v8.3.4
v8.4.0
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for
transport.ping_schedule
note that the transport clientdefaults to a 5s ping schedule, but this is no longer relevant. This
commit drops this from the docs, and also moves the docs for this
setting further down the page to reflect its relative unimportance.