-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message for stalled shutdown #89254
Merged
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2022-08-10-stalled-shutdown-contains-details
Aug 11, 2022
Merged
Fix message for stalled shutdown #89254
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2022-08-10-stalled-shutdown-contains-details
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if a node shutdown is stalled due to unmoveable shards then we say to use the allocation explain API to find details. In fact, since elastic#78727 we include the allocation explanation in the response already so we should tell users just to look at that instead. This commit adjusts the message to address this.
DaveCTurner
added
>bug
:Core/Infra/Node Lifecycle
Node startup, bootstrapping, and shutdown
Supportability
Improve our (devs, SREs, support eng, users) ability to troubleshoot/self-service product better.
v7.17.6
v8.4.1
v8.5.0
labels
Aug 10, 2022
Hi @DaveCTurner, I've created a changelog YAML for you. |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
grcevski
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 11, 2022
Today if a node shutdown is stalled due to unmoveable shards then we say to use the allocation explain API to find details. In fact, since elastic#78727 we include the allocation explanation in the response already so we should tell users just to look at that instead. This commit adjusts the message to address this.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2022
Today if a node shutdown is stalled due to unmoveable shards then we say to use the allocation explain API to find details. In fact, since #78727 we include the allocation explanation in the response already so we should tell users just to look at that instead. This commit adjusts the message to address this.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2022
Today if a node shutdown is stalled due to unmoveable shards then we say to use the allocation explain API to find details. In fact, since #78727 we include the allocation explanation in the response already so we should tell users just to look at that instead. This commit adjusts the message to address this. Backport of #89254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Core/Infra/Node Lifecycle
Node startup, bootstrapping, and shutdown
Supportability
Improve our (devs, SREs, support eng, users) ability to troubleshoot/self-service product better.
Team:Core/Infra
Meta label for core/infra team
v7.17.6
v8.4.0
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if a node shutdown is stalled due to unmoveable shards then we say
to use the allocation explain API to find details. In fact, since #78727
we include the allocation explanation in the response already so we
should tell users just to look at that instead. This commit adjusts the
message to address this.