Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] add an unattended mode setting to transform #89212

Merged
merged 10 commits into from
Aug 11, 2022
Merged

[Transform] add an unattended mode setting to transform #89212

merged 10 commits into from
Aug 11, 2022

Conversation

hendrikmuhs
Copy link

Add an unattended mode setting. This will change how transform reacts on certain error types and lets transform run without failing.

@elasticsearchmachine
Copy link
Collaborator

Hi @hendrikmuhs, I've created a changelog YAML for you.

@hendrikmuhs hendrikmuhs marked this pull request as ready for review August 10, 2022 15:30
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Aug 10, 2022
@hendrikmuhs hendrikmuhs force-pushed the transform-unattended branch from 14010e7 to 113f635 Compare August 10, 2022 17:29
droberts195
droberts195 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...form/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformFailureHandler.java Outdated Show resolved Hide resolved
@hendrikmuhs hendrikmuhs merged commit 6c12fe0 into elastic:main Aug 11, 2022
@szabosteve szabosteve mentioned this pull request Aug 15, 2022
Merged
@hendrikmuhs hendrikmuhs mentioned this pull request Aug 31, 2022
Merged
hendrikmuhs pushed a commit that referenced this pull request Sep 13, 2022
allow to start a transform if validation fails and let it start worki…
1cc5b9e 
…ng (#89759)

allow to start a transform if validation fails and let it start working once validation passes

relates #89212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hendrikmuhs @elasticsearchmachine @droberts195