Account for null metadata in update API key test
#89195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
changed the title
null metadata in update API key test
n1v0lg
commented
Aug 9, 2022
| "for api key doc " + actualRawApiKeyDoc, | ||
| // Internally, metadata may be stored as `null`. However, it is always exposed as an empty map through the API. We define | ||
| // `expectedMetadata` as the expected value according to the API, so we need to account for this discrepancy here | ||
| actualMetadata == null ? anEmptyMap() : actualMetadata, |
There was a problem hiding this comment.
I'm addressing the issue here, instead of going the other direction and accounting for null values on the GET API response. I think it is more intuitive to treat the API response as the expected result. We also run into an issue with null pointers if we try to pass a null value into expectAttributesForApiKey via Map.of(METADATA, null).
I would be up for only asserting on the API response, and removing expectMetadataForApiKey altogether.
n1v0lg
added
>test
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the metadata field on the raw API key doc is
null, the GET APIautomatically translates it to an empty map. This PR fixes a failing
test by accounting for this difference in a test assertion.
Closes #89193