Add logging in GlobalCheckpointSyncIT #89185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test GlobalCheckpointSyncIT#testBackgroundGlobalCheckpointSync failed once recently due to an engine already close exception. It has not occurred again and the reasoning is unclear. This commit adds a log line to indicate exactly when it happens, which shard it is, and what the current state of the index shard is. Closes elastic#88428.
Tim-Brooks
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
kingherc
reviewed
Aug 16, 2022
DaveCTurner
approved these changes
Aug 16, 2022
The exception gets thrown and ends up as the test failure. So that is why I left it out so it did not get printed twice? I mostly wanted to propagate the shard id and state if this happens again. Does this make sense? |
Yep, perfectly, just thought it worth checking. |
Yes pretty much just trying to catch in a face of an unexpected failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test GlobalCheckpointSyncIT#testBackgroundGlobalCheckpointSync
failed once recently due to an engine already close exception. It has
not occurred again and the reasoning is unclear.
This commit adds a log line to indicate exactly when it happens, which
shard it is, and what the current state of the index shard is.
Closes #88428.