[ML] fix NLP inference_config bwc serialization tests #89011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
|
@benwtrent Could you please add in the description what was causing the test failures? |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 2, 2022
The tests were failing because of span not being nulled out for question_answering and text_similarity tasks. But, this change also attempts to make it more future proof so that if changes occur to the nlp task or tokenization configurations it will cause a failure more quickly and require handling the bwc testing. closes: elastic#89008 (cherry picked from commit 480479d)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 2, 2022
…89042) * [ML] fix NLP inference_config bwc serialization tests (#89011) The tests were failing because of span not being nulled out for question_answering and text_similarity tasks. But, this change also attempts to make it more future proof so that if changes occur to the nlp task or tokenization configurations it will cause a failure more quickly and require handling the bwc testing. closes: #89008 (cherry picked from commit 480479d) * fixing backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing because of
spannot being nulled out for question_answering and text_similarity tasks.But, this change also attempts to make it more future proof so that if changes occur to the nlp task or tokenization configurations it will cause a failure more quickly and require handling the bwc testing.
closes: #89008