Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous switch/cases in ILM tests #88748

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Fix erroneous switch/cases in ILM tests #88748

merged 3 commits into from
Jul 23, 2022

Conversation

joegallo
Copy link
Contributor

Closes #88743

/cc @pugnascotia

joegallo added 3 commits July 22, 2022 16:44
@joegallo
Fix these switch/cases
4dd3027
@joegallo
Fix switch/case for RolloverActionTests
1a915d0 
As well as the revealed bug w.r.t. equals & hashCode.
@joegallo
Fix switch/case for ActionConfigStatsTests
af01f3d 
As well as the revealed bug w.r.t. equals & hashCode.
@joegallo joegallo added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jul 22, 2022
@joegallo joegallo requested a review from masseyke July 22, 2022 20:47
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

masseyke
masseyke approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:03
@joegallo joegallo merged commit be7c741 into elastic:main Jul 23, 2022
@joegallo joegallo deleted the fix-ilm-switch-cases branch July 23, 2022 01:12
@joegallo joegallo mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masseyke masseyke masseyke approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.17.6 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ILM tests have switches with impossible branches
3 participants
@joegallo @elasticsearchmachine @masseyke