Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable synthetic source support on constant keyword fields #88603

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Enable synthetic source support on constant keyword fields #88603

merged 2 commits into from
Jul 19, 2022

Conversation

romseygeek
Copy link
Contributor

This commit implements synthetic source support on constant keyword fields,
which will now always emit their value as part of the retrieved source.

@romseygeek romseygeek added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v8.4.0 labels Jul 19, 2022
@romseygeek romseygeek self-assigned this Jul 19, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @romseygeek, I've created a changelog YAML for you.

@romseygeek romseygeek requested review from jpountz and csoulios July 19, 2022 10:32
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

jpountz
jpountz reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to do a full review, but the change makes sense to me and properly tests the corner case when the constant value has not been configured yet, so this is good as far as I can tell.

csoulios
csoulios approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice improvement!

@romseygeek romseygeek merged commit 2f5ec51 into elastic:master Jul 19, 2022
@romseygeek romseygeek deleted the synthetic/constant_keyword branch July 19, 2022 16:08
@romseygeek romseygeek mentioned this pull request Jul 20, 2022
Closed
50 tasks
giladgal added a commit that referenced this pull request Nov 28, 2022
@giladgal
Update synthetic-source.asciidoc
f15055d 
There are at least two data types that are supported AFAIK and are not mentioned:
#88603
#89516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz left review comments

@csoulios csoulios csoulios approved these changes

Assignees

@romseygeek romseygeek

Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Clients Meta label for clients team Team:Search Meta label for search team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romseygeek @elasticmachine @elasticsearchmachine @jpountz @csoulios @sethmlarson