Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure new privs in API key update test #88602

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Ensure new privs in API key update test #88602

merged 5 commits into from
Jul 19, 2022

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Jul 19, 2022 •
edited
Loading

This PR ensures that we pick new cluster privileges when making a
non-noop API key update in tests for auto updating user fields.

Closes #88596.

@n1v0lg n1v0lg added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label labels Jul 19, 2022
@n1v0lg n1v0lg self-assigned this Jul 19, 2022
@n1v0lg n1v0lg changed the title Ensure new cluster privs in api key update test Ensure new privs in API key update test Jul 19, 2022
@n1v0lg n1v0lg marked this pull request as ready for review July 19, 2022 09:18
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jul 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@n1v0lg n1v0lg requested a review from ywangd July 19, 2022 09:18
ywangd
ywangd approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg n1v0lg merged commit 2605b9e into elastic:master Jul 19, 2022
@n1v0lg n1v0lg deleted the fix/test-failure-88596 branch July 19, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywangd ywangd ywangd approved these changes

Assignees

@n1v0lg n1v0lg

Labels
:Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] ApiKeyIntegTests testUpdateApiKeyAutoUpdatesUserFields failing
4 participants
@n1v0lg @elasticmachine @ywangd @elasticsearchmachine