Reduce boilerplate in plugins utils tests #88593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for PluginsUtils need to create many different plugin descriptors. But the vast majority of these just need a plugin name and dependencies. This commit adds a utility method to simplify these tests.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
reviewed
Jul 18, 2022
| @@ -38,6 +37,21 @@ | |||
| @LuceneTestCase.SuppressFileSystems(value = "ExtrasFS") | |||
| public class PluginsUtilsTests extends ESTestCase { | |||
|
|
|||
| PluginDescriptor newTestDescriptor(String name, List<String> deps) { | |||
There was a problem hiding this comment.
Maybe make deps variadic to avoid list creation by caller?
There was a problem hiding this comment.
We have to create a List for the descriptor regardless.
stu-elastic
approved these changes
Jul 18, 2022
rjernst
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for PluginsUtils need to create many different plugin descriptors.
But the vast majority of these just need a plugin name and dependencies.
This commit adds a utility method to simplify these tests.