Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one test for execution context in watcher compare condition #88466

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

sakurai-youhei
Copy link
Member

Issue: #88408

This PR adds one test for execution context in the watcher compare condition, which is equivalent to the below compare condition.

{
  "condition" : {
    "compare" : {
      "ctx.execution_time" : {
        "gte" : "<{now-5m}>"
      }
    }
  }
}

This test should always pass and actually passes in master branch but fails in 7.17 branch. So, backport PR will append necessary adjustment (bug fix) on top of this.

Question: I don't think this PR needs a changelog, right?

Add one test to confirm the below watcher compare condition is always
met.

```
  "condition": {
    "compare": {
      "ctx.execution_time": {
        "gte": "<{now-5m}>"
      }
    }
  }
```
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@rjernst rjernst added v8.4.0 and removed Team:Data Management Meta label for data/management team labels Jul 13, 2022
@stu-elastic stu-elastic self-requested a review July 13, 2022 16:50
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stu-elastic stu-elastic merged commit ece52f8 into elastic:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Watcher >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants