-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify azure discovery installation docs #88404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installation docs for azure discovery suggest installing Elasticsearch, and then verifying it is running. However, installation packages do not generally automatically start an installed service. For example, with systemd, once a package is installed it must be enabled and/or started explicitly. This commit removes wording about verifying Elasticsearch is running, as well as adjusts later docs about restarting it.
rjernst
added
>docs
General docs changes
:Distributed Coordination/Discovery-Plugins
Anything related to our integration plugins with EC2, GCP and Azure
v8.4.0
v8.2.3
v8.3.3
labels
Jul 9, 2022
elasticmachine
added
Team:Docs
Meta label for docs team
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
labels
Jul 9, 2022
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
debadair
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 14, 2022
The installation docs for azure discovery suggest installing Elasticsearch, and then verifying it is running. However, installation packages do not generally automatically start an installed service. For example, with systemd, once a package is installed it must be enabled and/or started explicitly. This commit removes wording about verifying Elasticsearch is running, as well as adjusts later docs about restarting it.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 14, 2022
The installation docs for azure discovery suggest installing Elasticsearch, and then verifying it is running. However, installation packages do not generally automatically start an installed service. For example, with systemd, once a package is installed it must be enabled and/or started explicitly. This commit removes wording about verifying Elasticsearch is running, as well as adjusts later docs about restarting it.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 15, 2022
* upstream/master: (2974 commits) Reserved cluster state service (elastic#88527) Add transport action immutable state checks (elastic#88491) Remove suggest flag from index stats docs (elastic#85479) Polling cluster formation state for master-is-stable health indicator (elastic#88397) Add test execution guide in yamlRestTest asciidoc (elastic#88490) Add troubleshooting guide for corrupt repository (elastic#88391) [Transform] Finetune Schedule to be less noisy on retry and retry slower (elastic#88531) Updatable API keys - auto-update legacy RDs (elastic#88514) Fix typo in TransportForceMergeAction and TransportClearIndicesCacheA… (elastic#88064) Fixed NullPointerException on bulk request (elastic#88358) Avoid needless index metadata builders during reroute (elastic#88506) Set metadata on request in API key noop test (elastic#88507) Fix passing positional args to ES in Docker (elastic#88502) Improve description for task api detailed param (elastic#88493) Support cartesian shape with doc values (elastic#88487) Promote usage of Subjects in Authentication class (elastic#88494) Add CCx 2.0 feature flag (elastic#88451) Reword the watcher 'always' and 'never' condition docs (elastic#86105) Simplify azure discovery installation docs (elastic#88404) Breakup FIPS CI testing jobs ... # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java # x-pack/plugin/mapper-aggregate-metric/src/main/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Discovery-Plugins
Anything related to our integration plugins with EC2, GCP and Azure
>docs
General docs changes
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
v8.3.3
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation docs for azure discovery suggest installing
Elasticsearch, and then verifying it is running. However, installation
packages do not generally automatically start an installed service. For
example, with systemd, once a package is installed it must be enabled
and/or started explicitly. This commit removes wording about verifying
Elasticsearch is running, as well as adjusts later docs about restarting
it. Additionally, the command to start Elasticsearch is fixed to use
systemctl, as SystemV init is no longer supported by our packages.