Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for query/agg on lookup runtime fields #88389

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Add tests for query/agg on lookup runtime fields #88389

merged 2 commits into from
Jul 8, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 8, 2022

Adds tests to ensure that querying and aggregating on lookup runtimes aren't supported.

Relates #88296

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.4.0 labels Jul 8, 2022
@dnhatn dnhatn requested a review from javanna July 8, 2022 15:22
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 8, 2022
javanna
javanna approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both yaml tests as well as IT tests? I was thinking either of the two is enough? A unit test that calls the relevant MappedFieldType methods would also be enough I think. Up to you though.

@dnhatn
Copy link
Member Author

dnhatn commented Jul 8, 2022

@javanna Thanks for review. I removed the IT tests and will keep only YAML tests.

@mark-vieira
Copy link
Contributor

Pinging @elastic/clients-team (Team:Clients)

@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 8, 2022
@elasticsearchmachine elasticsearchmachine merged commit 227d809 into elastic:master Jul 8, 2022
@dnhatn dnhatn deleted the lookup_runtime_field_tests branch July 8, 2022 16:32
@dnhatn dnhatn removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Clients Meta label for clients team Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnhatn @elasticmachine @mark-vieira @javanna @sethmlarson @elasticsearchmachine