[ML] indicate overall deployment failure if all node routes are failed #88378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>enhancement
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
davidkyle
approved these changes
Jul 12, 2022
| @@ -519,7 +519,15 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| out.writeOptionalVInt(queueCapacity); | |||
| out.writeInstant(startTime); | |||
| out.writeList(nodeStats); | |||
| out.writeOptionalEnum(state); | |||
| if (out.getVersion().onOrAfter(Version.V_8_4_0)) { | |||
There was a problem hiding this comment.
nit: the code could be structure in a way that makes it more explicit that the reason for these checks is that the FAILED state cannot be streamed to an < 8.4 node.
if (AssignmentState.FAILED.equals(state) && out.getVersion().before(Version.V_8_4_0)) {
out.writeOptionalEnum(AssignmentState.STARTING);
} else {
out.writeOptionalEnum(state);
}
…w-failed-deployment-state
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all node routes are failed, we should indicate that the whole deployment is failed through its assignment state.
The failures could be due to multiple reasons, so for detailed information, the individual node routing reasons should be investigated.