Drop username from AuthenticateRequest #88365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since transport client is no longer support for 8.x, the username field in AuthenticateRequest is not useful at all. At REST layer, the API never requires passing the username. Authentication should always be performed for the current authenticating/effective subject. This logic does not need to depend on the username. This PR drops the username field and makes the Request class a singleton. Relates: elastic#88335
ywangd
added
>refactoring
:Security/Authentication
|
Pinging @elastic/es-security (Team:Security) |
ywangd
commented
Jul 8, 2022
Comment on lines
39
to
41
| if (out.getVersion().before(Version.V_8_4_0)) { | ||
| throw new IllegalStateException("cannot send authenticate request to a node of earlier version"); | ||
| } |
There was a problem hiding this comment.
Throwing exception here since it is better to fail explicitly than guessing. But in practice this will never happen because AuthenticateRequest does not get sent across nodes.
tvernum
approved these changes
Aug 12, 2022
...ore/src/main/java/org/elasticsearch/xpack/core/security/action/user/AuthenticateRequest.java
Show resolved
Hide resolved
...ore/src/main/java/org/elasticsearch/xpack/core/security/action/user/AuthenticateRequest.java
Outdated
Show resolved
Hide resolved
…security/action/user/AuthenticateRequest.java Co-authored-by: Tim Vernum <[email protected]>
…thenticate-request
ywangd
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since transport client is no longer supported for 8.x, the username field
in AuthenticateRequest is not useful at all. At REST layer, the API
never requires passing the username. Authentication should always be
performed for the current authenticating/effective subject. This logic
does not need to depend on the username. This PR drops the username
field and makes the Request class a singleton.
Relates: #88335