Add build_flavor back to info api rest response #88336
Merged
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build_flavor was previously removed since it is no longer relevant; only the default distribution now exists. However, the removal of build flavor included removing it from the version information on the main response for the root path. This API is supposed to be stable, so removing that key was a compatibility break. This commit adds the build_flavor back to that API, hardcoded to `default`. closes elastic#88318
rjernst
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
|
Pinging @elastic/clients-team (Team:Clients) |
rjernst
added
auto-merge-without-approval
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 8, 2022
The build_flavor was previously removed since it is no longer relevant; only the default distribution now exists. However, the removal of build flavor included removing it from the version information on the info response for the root path. This API is supposed to be stable, so removing that key was a compatibility break. This commit adds the build_flavor back to that API, hardcoded to `default`. Additionally, a test is added to ensure the key exists going forward, until it can be properly deprecated. closes elastic#88318
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 8, 2022
The build_flavor was previously removed since it is no longer relevant; only the default distribution now exists. However, the removal of build flavor included removing it from the version information on the info response for the root path. This API is supposed to be stable, so removing that key was a compatibility break. This commit adds the build_flavor back to that API, hardcoded to `default`. Additionally, a test is added to ensure the key exists going forward, until it can be properly deprecated. closes #88318
rjernst
added a commit
that referenced
this pull request
Jul 8, 2022
tlrx
pushed a commit
to tlrx/elasticsearch
that referenced
this pull request
Jul 8, 2022
tlrx
added a commit
that referenced
this pull request
Jul 8, 2022
Reenable bwc tests after backport of #88336 on 8.3 branch. Co-authored-by: Ryan Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build_flavor was previously removed since it is no longer relevant;
only the default distribution now exists. However, the removal of build
flavor included removing it from the version information on the info
response for the root path. This API is supposed to be stable, so
removing that key was a compatibility break. This commit adds the
build_flavor back to that API, hardcoded to
default. Additionally, atest is added to ensure the key exists going forward, until it can be
properly deprecated.
closes #88318