Replace usages of deprecated specialized field exists queries #88312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocValueFieldExistsQuery, NormsFieldExistsQuery as well as KnnVectorFieldExistsQuery are deprecated in Lucene in favour of FieldExistsQuery which combines the three into a single query. This commit updates Elasticsearch to no longer rely on such deprecated queries. see https://issues.apache.org/jira/browse/LUCENE-10436
javanna
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @javanna, I've created a changelog YAML for you. |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 4, 2022
When we switched to using the FieldExistsQuery (see elastic#88312) instead of the deprecated NormsFieldExistsQuery and DocValuesFieldExistsQuery, we ended up shortcutting the total hit count for text fields to the doc count retrieved from the terms enum. This does not take into account empty strings, as that converts to an empty token set for text fields. In presence of text fields, we cannot shortcut, and this can be prevented by checking that the field has doc_values. This was checked before indirectly by checking that the query is a DocValuesFieldExistsQuery. Closes elastic#89760
javanna
added a commit
that referenced
this pull request
Oct 5, 2022
When we switched to using the FieldExistsQuery (see #88312) instead of the deprecated NormsFieldExistsQuery and DocValuesFieldExistsQuery, we ended up shortcutting the total hit count for text fields to the doc count retrieved from the terms enum. This does not take into account empty strings, as that converts to an empty token set for text fields. In presence of text fields, we cannot shortcut, and this can be prevented by checking that the field has doc_values. This was checked before indirectly by checking that the query is a DocValuesFieldExistsQuery. Closes #89760
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 5, 2022
When we switched to using the FieldExistsQuery (see elastic#88312) instead of the deprecated NormsFieldExistsQuery and DocValuesFieldExistsQuery, we ended up shortcutting the total hit count for text fields to the doc count retrieved from the terms enum. This does not take into account empty strings, as that converts to an empty token set for text fields. In presence of text fields, we cannot shortcut, and this can be prevented by checking that the field has doc_values. This was checked before indirectly by checking that the query is a DocValuesFieldExistsQuery. Closes elastic#89760
javanna
added a commit
that referenced
this pull request
Oct 5, 2022
When we switched to using the FieldExistsQuery (see #88312) instead of the deprecated NormsFieldExistsQuery and DocValuesFieldExistsQuery, we ended up shortcutting the total hit count for text fields to the doc count retrieved from the terms enum. This does not take into account empty strings, as that converts to an empty token set for text fields. In presence of text fields, we cannot shortcut, and this can be prevented by checking that the field has doc_values. This was checked before indirectly by checking that the query is a DocValuesFieldExistsQuery. Closes #89760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocValueFieldExistsQuery, NormsFieldExistsQuery as well as KnnVectorFieldExistsQuery are deprecated in Lucene in favour of FieldExistsQuery which combines the three into a single query.
This commit updates Elasticsearch to no longer rely on such deprecated queries.
see https://issues.apache.org/jira/browse/LUCENE-10436