Print full exception when console is non-interactive #88297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console logger truncates stack traces so a user is not bombarded with enormouse messages on startup. However, when the output is redirected to a file, there is no need to avoid large messages, and in fact it is a hinderance to debugging. This commit adds an internal flag to the console logging exception convert which disables the truncation when attached to a non-interactive console.
rjernst
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
grcevski
approved these changes
Jul 6, 2022
| */ | ||
| @Plugin(name = "consoleException", category = PatternConverter.CATEGORY) | ||
| @ConverterKeys({ "consoleException" }) | ||
| public class ConsoleThrowablePatternConverter extends ThrowablePatternConverter { | ||
| private ConsoleThrowablePatternConverter(String[] options, Configuration config) { | ||
|
|
||
| // true if exceptions shoudwhether exception formatting should always be delegated to the super class |
rjernst
added
the
auto-merge-without-approval
pugnascotia
reviewed
Jul 6, 2022
| } | ||
|
|
||
| @Override | ||
| public void format(final LogEvent event, final StringBuilder toAppendTo) { | ||
| Throwable error = event.getThrown(); | ||
| if (error == null) { | ||
| if (enabled == false | error == null) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console logger truncates stack traces so a user is not bombarded
with enormouse messages on startup. However, when the output is
redirected to a file, there is no need to avoid large messages, and in
fact it is a hinderance to debugging. This commit adds an internal flag
to the console logging exception convert which disables the truncation
when attached to a non-interactive console.