Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.3] Fix RandomSamplerIT#testRandomSamplerHistogram test input (#88191) #88288

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[8.3] Fix RandomSamplerIT#testRandomSamplerHistogram test input (#88191) #88288

merged 1 commit into from
Jul 5, 2022

Conversation

benwtrent
Copy link
Member

Backports the following commits to 8.3:

@benwtrent
Fix RandomSamplerIT#testRandomSamplerHistogram test input (elastic#88191
80d4266 
)

Periodically, a single 10 value is included which causes a 3rd histogram bucket to be created with very few values. Meaning sampling wouldn't get any docs that hit that bucket (especially with the randomly included deleted docs).

The failures that I saw had the 10.0 bucket with just one document.

closes: elastic#88108
@benwtrent benwtrent added :Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jul 5, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 5, 2022
Merged
@elasticsearchmachine elasticsearchmachine merged commit 4e6b148 into elastic:8.3 Jul 5, 2022
@benwtrent benwtrent deleted the backport/8.3/pr-88191 branch July 5, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwtrent @elasticmachine @elasticsearchmachine