Fix checkstyle version drift and API change #88283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>bug
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Why didn’t the build fail with this conflict? Can we fail going forward in this situation so that we don’t have this jarhell again? |
breskeby
approved these changes
Jul 5, 2022
...ions/src/main/java/org/elasticsearch/gradle/internal/checkstyle/MissingJavadocTypeCheck.java
Outdated
Show resolved
Hide resolved
|
We don't apply the custom Checkstyle in the CLI build, only in the IDE. We would have caught this if we didn't duplicate the Checkstyle version declaration. @breskeby said he'd look into consolidating them. |
…nal/checkstyle/MissingJavadocTypeCheck.java Co-authored-by: Rene Groeschke <[email protected]>
mark-vieira
approved these changes
Jul 5, 2022
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Jul 5, 2022
Fix checkstyle version drift and API change.
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Jul 5, 2022
Fix checkstyle version drift and API change.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 5, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 5, 2022
breskeby
added a commit
that referenced
this pull request
Jul 15, 2022
We only rely on the checkstyle version in the buildLibs.toml gradle version catalogue with this change. Also added some hints for gradle best practices. This is an aftermath of #88283
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 18, 2022
We only rely on the checkstyle version in the buildLibs.toml gradle version catalogue with this change. Also added some hints for gradle best practices. This is an aftermath of elastic#88283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we have the Checkstyle version in 2 places:
build-tools-internal/version.propertiesgradle/build.versions.tomlThis concealed that there was an API change between 10.1 and 10.3, and we needed to update one of our custom checks.