Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Remove external herokuapp website link #87968

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[doc] Remove external herokuapp website link #87968

merged 1 commit into from
Jun 28, 2022

Conversation

pgomulka
Copy link
Contributor

backports #77405

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka pgomulka added >docs General docs changes v7.7.2 labels Jun 23, 2022
@pgomulka pgomulka self-assigned this Jun 23, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 23, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

jkakavas
jkakavas approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka
Copy link
Contributor Author

@elastic/es-delivery do you know if this build fails, will it get uploaded online?
I suppose the build failure is due to CI no longer being set up for this old branch

@debadair debadair merged commit ef7d398 into 7.7 Jun 28, 2022
@debadair debadair deleted the 7.7_herokuapp_link_remove branch June 28, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkakavas jkakavas jkakavas approved these changes

Assignees
No one assigned
Labels
>docs General docs changes Team:Docs Meta label for docs team v7.7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @jkakavas @debadair