Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed error messages for searchable snapshot shared folder assertions #87497

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Jun 8, 2022

#86186 doesn't reproduce locally. Let's add some additional information to assertions to have more information about how assertShardFolders fails on CI (in rare cases when it does).

Fixes #86186

@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. labels Jun 8, 2022
@arteam arteam marked this pull request as ready for review June 8, 2022 12:52
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@arteam arteam requested review from idegtiarenko and tlrx June 20, 2022 17:56
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit bd03912 into elastic:master Jun 27, 2022
@arteam arteam deleted the add-shared-folder-error-messages branch June 27, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] FrozenSearchableSnapshotsIntegTests testCreateAndRestorePartialSearchableSnapshot failing
4 participants