Deduplicate mappings in persisted cluster state #87126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
WIP
:Distributed Coordination/Cluster Coordination
|
We discussed this recently and decided that Joe is going to move this forwards. |
to reflect specifically that there's no action required for an index, specifically
There's no tracking of 'mappings changed' because we're storing things by hash, so mappings are removed and/or added but we can't see 'changes' as a reified thing.
The behavior of writeIncrementalStateAndCommit relies on the previousState that we pass in actually being a correct representation of the on-disk state -- this test did not respect that. Rather, it did clusterState->newClusterState twice in a row, so now we inject a null->clusterState between the two so that everything works right. Also we're doing more writes now, so I bumped the 14 constant to 16.
|
Closing in favor of #88479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP