Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract transport cluster settings/ilm execute logic #86941

Merged
merged 2 commits into from
May 25, 2022

Conversation

grcevski
Copy link
Contributor

Extract the execute logic from the transport actions for cluster update settings and ILM put/delete to support future reuse for operator file based updates.

This PR serves as a base for the follow-up work to actually implement file based settings. There's no particular reason why these two were chosen, other than diversity of operations: settings vs entities and elasticsearch core vs plugin.

Relates to #86224

Extract execute logic from the transport actions for cluster
update settings and ILM put/delete to support future reuse for
operator file based updates.

Relates to elastic#86224
@grcevski grcevski added >non-issue :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.3.0 labels May 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@grcevski grcevski requested review from DaveCTurner and dakrone May 19, 2022 22:05
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski grcevski merged commit fbf335d into elastic:master May 25, 2022
@grcevski grcevski deleted the refactor_cluster_handlers branch May 25, 2022 13:41
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request May 26, 2022
Extract execute logic from the transport actions for cluster
update settings and ILM put/delete to support future reuse for
operator file based updates.

Relates to elastic#86224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants