Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected an incomplete sentence. #86542

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Corrected an incomplete sentence. #86542

merged 2 commits into from
Jul 12, 2022

Conversation

local-ghost-127
Copy link
Contributor

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.3.0 labels May 9, 2022
@cbuescher cbuescher added >docs General docs changes :Analytics/Aggregations Aggregations labels May 16, 2022
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels May 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 requested a review from csoulios May 16, 2022 16:13
@csoulios csoulios self-assigned this May 17, 2022
@csoulios csoulios mentioned this pull request May 17, 2022
Closed
2 tasks
csoulios
csoulios suggested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing this.

I added a small change suggestion.

docs/reference/aggregations/metrics/avg-aggregation.asciidoc Outdated Show resolved Hide resolved
@kilfoyle kilfoyle requested a review from csoulios July 12, 2022 13:14
kilfoyle
kilfoyle approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Christos' change included.

csoulios
csoulios approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 67cacde into elastic:master Jul 12, 2022
@csoulios csoulios mentioned this pull request Jul 12, 2022
Merged
csoulios added a commit to csoulios/elasticsearch that referenced this pull request Jul 12, 2022
@local-ghost-127 @kilfoyle @csoulios
Corrected an incomplete sentence. (elastic#86542)
16dc936 
* Corrected an incomplete sentence.

* Update docs/reference/aggregations/metrics/avg-aggregation.asciidoc

Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Christos Soulios <[email protected]>
@csoulios csoulios mentioned this pull request Jul 12, 2022
Merged
csoulios added a commit to csoulios/elasticsearch that referenced this pull request Jul 12, 2022
@local-ghost-127 @kilfoyle @csoulios
Corrected an incomplete sentence. (elastic#86542)
fc88221 
* Corrected an incomplete sentence.

* Update docs/reference/aggregations/metrics/avg-aggregation.asciidoc

Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Christos Soulios <[email protected]>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.2
✅ 8.3

@kilfoyle
Copy link
Contributor

Thanks a lot for adding this @local-ghost-127!

elasticsearchmachine pushed a commit that referenced this pull request Jul 12, 2022
@csoulios @local-ghost-127 @kilfoyle
Corrected an incomplete sentence. (#86542) (#88472)
9447e0d 
* Corrected an incomplete sentence.

* Update docs/reference/aggregations/metrics/avg-aggregation.asciidoc

Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: Sean Letendre <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jul 12, 2022
@csoulios @local-ghost-127 @kilfoyle
Corrected an incomplete sentence. (#86542) (#88473)
694622f 
* Corrected an incomplete sentence.

* Update docs/reference/aggregations/metrics/avg-aggregation.asciidoc

Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Christos Soulios <[email protected]>

Co-authored-by: Sean Letendre <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 13, 2022
@weizijun
Merge branch 'upstream/master' into rollup-support-cancel
00089cc 
* upstream/master: (38 commits)
  Simplify map copying (elastic#88432)
  Make DiffableUtils.diff implementation agnostic (elastic#88403)
  Ingest: Start separating Metadata from IngestSourceAndMetadata (elastic#88401)
  Move runtime fields base scripts out of scripting fields api package. (elastic#88488)
  Enable TRACE Logging for test and increase timeout (elastic#88477)
  Mute ReactiveStorageIT#testScaleDuringSplitOrClone (elastic#88480)
  Track the count of failed invocations since last successful policy snapshot (elastic#88398)
  Avoid noisy exceptions on data nodes when aborting snapshots (elastic#88476)
  Fix ReactiveStorageDeciderServiceTests testNodeSizeForDataBelowLowWatermark (elastic#88452)
  INFO logging of snapshot restore and completion (elastic#88257)
  unmute test (elastic#88454)
  Updatable API keys - noop check (elastic#88346)
  Corrected an incomplete sentence. (elastic#86542)
  Use consistent shard map type in IndexService (elastic#88465)
  Stop registering TestGeoShapeFieldMapperPlugin in ESIntegTestCase (elastic#88460)
  TSDB: RollupShardIndexer logging improvements (elastic#88416)
  Audit API key ID when create or grant API keys (elastic#88456)
  Bound random negative size test in SearchSourceBuilderTests#testNegativeSizeErrors (elastic#88457)
  Updatable API keys - logging audit trail event (elastic#88276)
  Polish reworked LoggedExec task (elastic#88424)
  ...

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csoulios csoulios csoulios approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees

@csoulios csoulios

Labels
:Analytics/Aggregations Aggregations >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.2.4 v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@local-ghost-127 @elasticmachine @elasticsearchmachine @kilfoyle @csoulios @craigtaverner @cbuescher