Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message in guessRootCauses #86280

Closed
wants to merge 1 commit into from
Closed

Conversation

yan4105
Copy link

@yan4105 yan4105 commented Apr 29, 2022

Just hoping to inspire better solutions, with respect to #85127 and follow up discussion #85774 where it seems a better error message for the users is needed, I suggest returning the method names that appear in the stack trace joined by “->”.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
fa4b531

Please, read and sign the above mentioned agreement if you want to contribute to this project

@elasticsearchmachine elasticsearchmachine added v8.3.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 29, 2022
@jtibshirani jtibshirani added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@jtibshirani
Copy link
Contributor

I tagged the analytics/ geo team because it relates to your previous discussions. Feel free to remove or relabel.

@nik9000 nik9000 requested a review from not-napoleon May 18, 2022 20:49
@not-napoleon
Copy link
Member

I'm going to close this. Stack traces don't make good error messages. They tend to be long, sometimes very long, and are essentially useless to an end user. For developers, we have the error_trace=true query parameter to get a full trace as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants