Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Remove references to bootstrap.system_call_filter (#85964) #85971

Closed
wants to merge 1 commit into from
Closed

[8.0] Remove references to bootstrap.system_call_filter (#85964) #85971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/reference/setup/bootstrap-checks.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,9 @@ filters are installed to prevent the ability to execute system calls
related to forking as a defense mechanism against arbitrary code
execution attacks on Elasticsearch. The system call filter check ensures
that if system call filters are enabled, then they were successfully
installed. To pass the system call filter check you must either fix any
installed. To pass the system call filter check you must fix any
configuration errors on your system that prevented system call filters
from installing (check your logs), or *at your own risk* disable system
call filters by setting `bootstrap.system_call_filter` to `false`.
from installing (check your logs).

=== OnError and OnOutOfMemoryError checks

Expand Down
7 changes: 1 addition & 6 deletions server/src/main/java/org/elasticsearch/bootstrap/BootstrapSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ private BootstrapSettings() {}
);

public static final Setting<Boolean> MEMORY_LOCK_SETTING = Setting.boolSetting("bootstrap.memory_lock", false, Property.NodeScope);
public static final Setting<Boolean> SYSTEM_CALL_FILTER_SETTING = Setting.boolSetting(
"bootstrap.system_call_filter",
true,
Property.DeprecatedWarning,
Property.NodeScope
);

public static final Setting<Boolean> CTRLHANDLER_SETTING = Setting.boolSetting("bootstrap.ctrlhandler", true, Property.NodeScope);

}
7 changes: 1 addition & 6 deletions server/src/test/java/org/elasticsearch/bootstrap/BootstrapChecksTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,7 @@ String getUseSerialGC() {

public void testSystemCallFilterCheck() throws NodeValidationException {
final AtomicBoolean isSystemCallFilterInstalled = new AtomicBoolean();
final BootstrapContext context;
if (randomBoolean()) {
context = createTestContext(Settings.builder().put("bootstrap.system_call_filter", true).build(), null);
} else {
context = emptyContext;
}
final BootstrapContext context = emptyContext;

final BootstrapChecks.SystemCallFilterCheck systemCallFilterEnabledCheck = new BootstrapChecks.SystemCallFilterCheck() {

Expand Down