Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix serialisation of text embedding updates #85863

Merged
merged 3 commits into from
Apr 13, 2022
Merged

[ML] Fix serialisation of text embedding updates #85863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bc08e0
Fix serialisation of text embedding updates
davidkyle Apr 13, 2022
c38cf34
Update docs/changelog/85863.yaml
davidkyle Apr 13, 2022
bd43d00
spotless
davidkyle Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/85863.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 85863
summary: Fix serialisation of text embedding updates
area: Machine Learning
type: bug
issues: []
6 changes: 1 addition & 5 deletions ...main/java/org/elasticsearch/xpack/core/ml/inference/MlInferenceNamedXContentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,11 +600,7 @@ public List<NamedWriteableRegistry.Entry> getNamedWriteables() {
)
);
namedWriteables.add(
new NamedWriteableRegistry.Entry(
InferenceConfigUpdate.class,
TextEmbeddingConfigUpdate.NAME,
TextClassificationConfigUpdate::new
)
new NamedWriteableRegistry.Entry(InferenceConfigUpdate.class, TextEmbeddingConfigUpdate.NAME, TextEmbeddingConfigUpdate::new)
);
namedWriteables.add(
new NamedWriteableRegistry.Entry(
Expand Down