Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ordering terms aggregation on top metrics null values #85774

Merged
merged 15 commits into from
Apr 19, 2022
Merged

fix: ordering terms aggregation on top metrics null values #85774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5b2d243
fix: ordering terms aggregation on top metrics null values
salvatore-campagna Mar 23, 2022
73269ab
Update docs/changelog/85774.yaml
salvatore-campagna Apr 11, 2022
c0990b0
test: remove test as a result of using existing yaml tests
salvatore-campagna Apr 11, 2022
0b93430
fix: move top_metrics tests to x-pack
salvatore-campagna Apr 11, 2022
60c41a3
fix: duplicate yaml test name
salvatore-campagna Apr 11, 2022
abb5fe2
fix: duplicate yaml test name
salvatore-campagna Apr 11, 2022
5cb7f45
Merge branch 'master' into fix/85127-top-metrics-index-out-of-bounds
elasticmachine Apr 11, 2022
f7c0df8
fix: move index out of body inside search
salvatore-campagna Apr 11, 2022
db8d5e0
fix: use the unknown_metric in top_metrics agg
salvatore-campagna Apr 11, 2022
c61d11a
Merge branch 'master' into fix/85127-top-metrics-index-out-of-bounds
elasticmachine Apr 11, 2022
c6d9edb
fix: use the unknown_metric in top_metrics agg
salvatore-campagna Apr 11, 2022
bbbcf94
fix: use actual field names for non existing metrics
salvatore-campagna Apr 12, 2022
440b2c2
Merge branch 'master' into fix/85127-top-metrics-index-out-of-bounds
elasticmachine Apr 12, 2022
fc02ec5
fix: code format
salvatore-campagna Apr 12, 2022
6d6e019
fix: escape square brakets
salvatore-campagna Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/85774.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 85774
summary: "Fix: ordering terms aggregation on top metrics null values"
area: Aggregations
type: bug
issues: []
5 changes: 4 additions & 1 deletion ...tics/src/main/java/org/elasticsearch/xpack/analytics/topmetrics/TopMetricsAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,9 @@ static class DoubleMetricValues extends CollectingMetricValues {

@Override
public double doubleValue(long index) {
if (index < 0 || index >= values.size()) {
return Double.NaN;
}
return values.get(index);
}

Expand Down Expand Up @@ -357,7 +360,7 @@ static class LongMetricValues extends CollectingMetricValues {

@Override
public double doubleValue(long index) {
if (empty.isEmpty(index)) {
if (empty.isEmpty(index) || index < 0 || index >= values.size()) {
return Double.NaN;
}
return values.get(index);
Expand Down
Loading