Use Set instead of LongSet in double script field #85475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double script field uses hppc's LongSet to store the unique values to be queried. However, this set should be relatively small. This commit changes the internals of the runtime double script field to use Set. relates elastic#84735
rjernst
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
approved these changes
Mar 30, 2022
| @@ -66,8 +64,8 @@ public boolean equals(Object obj) { | |||
| double[] terms() { | |||
| double[] result = new double[terms.size()]; | |||
| int i = 0; | |||
| for (LongCursor lc : terms) { | |||
| result[i++] = Double.longBitsToDouble(lc.value); | |||
| for (long l : terms) { | |||
There was a problem hiding this comment.
nit: maybe replace this with stream/mapToDouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double script field uses hppc's LongSet to store the unique values
to be queried. However, this set should be relatively small. This commit
changes the internals of the runtime double script field to use Set.
relates #84735