Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the hppc ObjectArrayList from CollectionUtils.sortAndDedup #85305

Conversation

pgomulka
Copy link
Contributor

The objectArrayList can be replaced with java.util.ArrayList to achieve
in situ sorting and deduplication.

relates #84735

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

The objectArrayList can be replaced with java.util.ArrayList to achieve
in place sorting and deduplication.

relates  elastic#84735
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label >refactoring v8.2.0 labels Mar 24, 2022
@pgomulka pgomulka self-assigned this Mar 24, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka
Copy link
Contributor Author

btw I was looking into org.elasticsearch.common.util and wanted to clean this package, but I am not sure what to do with com.carrotsearch.hppc.BitMixer. Should we copy it?
It deserves a separate PR anyway

@pgomulka pgomulka requested a review from rjernst March 24, 2022 12:04
@rjernst
Copy link
Member

rjernst commented Mar 25, 2022

I've actually rewritten this method in a different way: #85352

I am not sure what to do with com.carrotsearch.hppc.BitMixer. Should we copy it?

Yes, I think the 2 methods which are used should be copied. They are based on published methodologies. There is an existing BitUtil class. It could be moved to core lib and the mix methods added there.

@pgomulka
Copy link
Contributor Author

makes sense, I am closing this in favour of #85352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants