Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing getter #84912

Merged
merged 2 commits into from
Jul 7, 2022
Merged

add missing getter #84912

merged 2 commits into from
Jul 7, 2022

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Mar 12, 2022

  • Have you signed the contributor license agreement? - YES
  • Have you followed the contributor guidelines? - YES
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. - YES
  • If submitting code, have you checked that your submission is for an OS and architecture that we support? - N/A
  • If you are submitting this code for a class then read our policy for that. - NO

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.2.0 labels Mar 12, 2022
@nik9000 nik9000 self-assigned this Mar 15, 2022
@nik9000
Copy link
Member

nik9000 commented Mar 15, 2022

What's the getter for? I think this thing is pretty internal. Does a plugin need it?

@nik9000 nik9000 added the :Core/Infra/Core Core issues without another label label Mar 15, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 15, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@nik9000 nik9000 added :Data Management/Stats Statistics tracking and retrieval APIs and removed :Core/Infra/Core Core issues without another label labels Mar 15, 2022
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team and removed Team:Core/Infra Meta label for core/infra team labels Mar 15, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@mindw
Copy link
Contributor Author

mindw commented Mar 15, 2022

@nik9000 yes - the getters are used in the Prometheus exporter plugin https://github.com/vvanholl/elasticsearch-prometheus-exporter. I'm mid-updating with (semi)recent metric changes.

There several more of those I'll try bunching them up.

@nik9000 nik9000 removed their assignment Mar 15, 2022
@nik9000
Copy link
Member

nik9000 commented Mar 15, 2022

Cool. I've unassigned myself here and left it for the experts in stats to have their opinion.

@mindw
Copy link
Contributor Author

mindw commented Jul 3, 2022

@dakrone any chance you can look at this as well? Tx!

@mindw mindw mentioned this pull request Jul 3, 2022
@dakrone dakrone self-requested a review July 7, 2022 15:48
@dakrone dakrone self-assigned this Jul 7, 2022
@dakrone
Copy link
Member

dakrone commented Jul 7, 2022

@elasticmachine update branch

@dakrone
Copy link
Member

dakrone commented Jul 7, 2022

@elasticmachine ok to test

@dakrone dakrone added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 7, 2022
@elasticsearchmachine elasticsearchmachine merged commit f2dd32e into elastic:master Jul 7, 2022
@mindw mindw deleted the patch-3 branch July 7, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Stats Statistics tracking and retrieval APIs external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Data Management Meta label for data/management team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants