Shrink slow log for has_child query #83870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
This removes the defaults from the `toXContent` of the `has_child` query so slow logs that contain it are marginally easier to read. Relates to elastic#76515
romseygeek
approved these changes
Feb 12, 2022
| checkGeneratedJson(query, queryBuilder); | ||
| checkGeneratedJson( | ||
| /* | ||
| * Ignoring unampped is the default and we don't dump it and can't |
| } | ||
| }""", parseQuery(query)); | ||
| } | ||
|
|
nik9000
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the defaults from the
toXContentof thehas_childqueryso slow logs that contain it are marginally easier to read.
Relates to #76515