Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use switch expressions in EnableAllocationDecider and NodeShutdownAllocationDecider #83641

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Feb 8, 2022

No description provided.

@arteam arteam added >non-issue :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >refactoring labels Feb 8, 2022
@arteam
Copy link
Contributor Author

arteam commented Feb 8, 2022

@elasticmachine
run elasticsearch-ci/part-1
run elasticsearch-ci/bwc

@arteam arteam force-pushed the allocation-switch-expressions branch from fe21113 to 178dea2 Compare February 8, 2022 13:30
@arteam arteam marked this pull request as ready for review February 8, 2022 15:24
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Feb 8, 2022
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

@arteam arteam added auto-backport Automatically create backport pull requests when merged v8.1.1 labels Feb 8, 2022
@arteam arteam merged commit 4108dab into elastic:master Feb 8, 2022
@arteam arteam deleted the allocation-switch-expressions branch February 8, 2022 18:00
@arteam
Copy link
Contributor Author

arteam commented Feb 8, 2022

Thanks David!

arteam added a commit to arteam/elasticsearch that referenced this pull request Feb 8, 2022
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.1

arteam added a commit that referenced this pull request Feb 8, 2022
…ocationDecider (#83641) (#83673)

* Reverse condition for replicas
@DaveCTurner
Copy link
Contributor

Oh I don't think this should have been backported to 8.1, it's not a bugfix. It was only labelled as 8.2 when I LGTMd it. Would you revert that backport please?

@arteam
Copy link
Contributor Author

arteam commented Feb 8, 2022

Sure, no problem 👍

arteam added a commit that referenced this pull request Feb 8, 2022
arteam added a commit that referenced this pull request Feb 8, 2022
@arteam arteam removed the v8.1.1 label Feb 8, 2022
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Feb 9, 2022
* upstream/master: (166 commits)
  Bind host all instead of just _site_ when needed (elastic#83145)
  [DOCS] Fix min/max agg snippets for histograms (elastic#83695)
  [DOCS] Add deprecation notice for system indices (elastic#83688)
  Cache ILM policy name on IndexMetadata (elastic#83603)
  [DOCS] Fix 8.0 breaking changes sort order (elastic#83685)
  [ML] fix random sampling background query consistency (elastic#83676)
  Move internal APIs into their own namespace '_internal'
  Runtime fields core-with-mapped tests support tsdb (elastic#83577)
  Optimize calculating the presence of a quorum (elastic#83638)
  Use switch expressions in EnableAllocationDecider and NodeShutdownAllocationDecider (elastic#83641)
  Note libffi error message in tmpdir docs (elastic#83662)
  Fix TransportDesiredNodesActionsIT batch tests (elastic#83659)
  [DOCS] Remove unused upgrade doc files (elastic#83617)
  [ML] Wait for model process to stop in stop deployment (elastic#83644)
  [ML] Fix submit after shutdown in process worker service (elastic#83645)
  Remove req/resp classes associated with HLRC (elastic#83599)
  Introduce index.version.compatibility setting (elastic#83264)
  Rename InternalTestCluster#getMasterNodeInstance (elastic#83407)
  Mute TimeSeriesIndexSearcherTests testCollectInOrderAcrossSegments (elastic#83648)
  Add rollover add max_primary_shard_docs condition (elastic#80981)
  ...

# Conflicts:
#	x-pack/plugin/rollup/build.gradle
#	x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue >refactoring Team:Distributed Meta label for distributed team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants