Fix and unmute package upgrade tests #83043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkakavas
added
the
:Delivery/Packaging
|
@elasticsearchmachine run elasticsearch-ci/packaging-upgrade-tests |
jkakavas
changed the title
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Jan 26, 2022
| @@ -75,15 +75,13 @@ public void test10SecurityAutoConfiguredOnPackageInstall() throws Exception { | |||
| public void test20SecurityNotAutoConfiguredOnReInstallation() throws Exception { | |||
| // we are testing force upgrading in the current version | |||
| // In such a case, security remains configured from the initial installation, we don't run it again. | |||
| Optional<String> autoConfigDirName = getAutoConfigDirName(installation); | |||
| byte[] transportKeystore = Files.readAllBytes(installation.config("certs").resolve("transport.p12")); | |||
There was a problem hiding this comment.
Should we be using AUTOCONFIG_DIRNAME instead of "certs" here?
pugnascotia
reviewed
Jan 26, 2022
| assertThat(getAutoConfigDirName(installation).isPresent(), is(true)); | ||
| assertThat(getAutoConfigDirName(installation).get(), equalTo(autoConfigDirName.get())); | ||
| // Since we did not auto-configure the second time, the keystore should be the one we generated the first time, above | ||
| assertThat(transportKeystore, equalTo(Files.readAllBytes(installation.config("certs").resolve("transport.p12")))); |
There was a problem hiding this comment.
Again, should we be using AUTOCONFIG_DIRNAME instead of "certs" here?
pugnascotia
approved these changes
Jan 26, 2022
|
a |
|
💚 CLA has been signed |
jkakavas
force-pushed
the
fix-upgrade-test
branch
from
3660224 to
240e375
Compare
jkakavas
added
the
auto-backport
This was referenced Jan 27, 2022
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jan 27, 2022
Fixes PackageUpgradeTests (cherry picked from commit 514bec1)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jkakavas
added a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes package upgrade tests and unmutes failing tests
resolves: #79950, #76283