Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dynamic settings specified by deprecation.skip_deprecated_settings in node deprecation checks #82883

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Jan 20, 2022

This commit makes it so that the NodeDeprecationChecks part of the deprecation info API will ignore settings
specified by deprecation.skip_deprecated_settings, even if those settings are dynamically set.
Closes #82889

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment, I think we can do this without opening up the Metadata constructor or making a subclass

@masseyke
Copy link
Member Author

In addition to the unit test, I did the following:
I brought up a new 7.17.0-SNAPSHOT cluster with this in its elasticsearch.yml:

deprecation.skip_deprecated_settings:
 - "discovery.zen.minimum_master_nodes"

I added two deprecated dynamic properties (but only one is listed in deprecation.skip_deprecated_settings):

PUT /_cluster/settings
{
  "transient": {
    "discovery.zen.minimum_master_nodes": "2"
  }
}

PUT /_cluster/settings
{
  "transient": {
    "discovery.zen.commit_timeout": "40s"
  }
}

Then I did

GET _migration/deprecations

And only discovery.zen.commit_timeout came back, as expected.

@masseyke masseyke requested a review from dakrone January 20, 2022 21:40
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Keith!

@jakelandis
Copy link
Contributor

@masseyke - Thank you for the fast turn around time !

@masseyke masseyke merged commit 408dc51 into elastic:7.17 Jan 20, 2022
@masseyke masseyke deleted the fix/support-ignoring-dynamic-settings branch January 20, 2022 22:28
@albertzaharovits albertzaharovits changed the title Ignoring dynamic settings specified by deprecation.skip_deprecated_settings in node deprecation checks Ignore dynamic settings specified by deprecation.skip_deprecated_settings in node deprecation checks Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Team:Data Management Meta label for data/management team v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants