-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore dynamic settings specified by deprecation.skip_deprecated_settings in node deprecation checks #82883
Ignore dynamic settings specified by deprecation.skip_deprecated_settings in node deprecation checks #82883
Conversation
…ttings in node deprecation checks
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment, I think we can do this without opening up the Metadata
constructor or making a subclass
...n/src/main/java/org/elasticsearch/xpack/deprecation/TransportNodeDeprecationCheckAction.java
Outdated
Show resolved
Hide resolved
In addition to the unit test, I did the following:
I added two deprecated dynamic properties (but only one is listed in
Then I did
And only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Keith!
@masseyke - Thank you for the fast turn around time ! |
This commit makes it so that the NodeDeprecationChecks part of the deprecation info API will ignore settings
specified by deprecation.skip_deprecated_settings, even if those settings are dynamically set.
Closes #82889