-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention bind-mounting plugins dir in Docker docs #82622
Mention bind-mounting plugins dir in Docker docs #82622
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Rory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some suggestions and comments, but none of those are blocking.
* Alternatively, you must bind-mound the `config`, `data` and `logs` | ||
directories. You must also bind-mount the `plugins` directory if you | ||
intend to install plugins and prefer not to <<_c_customized_image, create a | ||
custom Docker image>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move the bind-mounting bullet first? I imagine most admins are using Docker compose in production so I'm not sure if we want to highlight the docker run
option first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure which option an admin would prefer, but I do suspect that people following the guide to get something up-and-running would be better off using the bind-mounts, so I've swapped the options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine most admins are using Docker compose in production so I'm not sure if we want to highlight the docker run option first.
FWIW, I don't think folks using our Docker images in production are using either of these options. They are likely using Kubernetes or some other orchestrator or config as code mechanism to deploy. That's just my intuition though.
Co-authored-by: James Rodewig <[email protected]>
Thanks @jrodewig! |
Closes #69533. The Docker docs mention bind-mounting the `config`, `data` and `logs` directories when using an arbitrary UID / GID, but they fail to mention that the `plugins` dir must also be mounted in order to install plugins.
Closes #69533. The Docker docs mention bind-mounting the `config`, `data` and `logs` directories when using an arbitrary UID / GID, but they fail to mention that the `plugins` dir must also be mounted in order to install plugins.
Closes #69533.
The Docker docs mention bind-mounting the
config
,data
andlogs
directories when using an arbitrary UID / GID, but they fail to mention that theplugins
dir must also be mounted in order to install plugins.