[8.0] SQL: Remove JDBC dependency on ES XContent lib (#82225) #82267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove JDBC driver dependency on XContent by cloning the necessary classes into the driver. This has the advantage of keeping the parsing/writing code style in sync and hopefully making maintenance easier in the future at the cost of bringing over a lot of code that is potentially unnecessary. The imported classes were kept as close as possible to the original and placed under a different package. Noteable exception is JDBC XContentBuilder which exposes its internal generator to allow unwrapping inside sql-action. The bridging between XContent in ES and JDBC is done in sql-action through ProtoShim which relies on delegation to allow ES XContent to be used inside the JDBC classes. Fix elastic#80277
costin
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: