Allow read template with cluster monitor privilege #82046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilge so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554, elastic#78832
tvernum
added
>enhancement
:Data Management/Indices APIs
elasticmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Pinging @elastic/es-security (Team:Security) |
jakelandis
reviewed
Dec 27, 2021
There was a problem hiding this comment.
It feels a bit off to have indices:admin/[template|component_template|index_template]/get working as a cluster:monitor/* . I understand changing the name is technically non-passive so maybe the question is specific to 8.0.0 ... but I wonder if it would be better to change the name of the actions to indices:monitor/[template|component_template|index_template]/get and update the MONITOR_PATTERN to include both cluster:monitor/* and indices/monitor/* ? Some other existing actions would come along for the ride, but it looks like that might have been the original intent of those actions.
FWIW, I am fine with the change as-is for 7.17.
|
I does feel a bit off, but I think the issue is that we're hitting the limits of what you can reasonably do with a hierarchical naming system. If we rename the Get actions, then it means that the template actions are no longer under a single hierarchy and anyone with existing roles like: would no longer have access to get templates. I'm not opposed to renaming the action, but I think this is a sign that we're getting to the point where relying on a action naming system is no longer sufficient for us. |
dakrone
approved these changes
Jan 4, 2022
|
@elasticmachine update branch |
tvernum
added
the
auto-merge-without-approval
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 5, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilege so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554 Relates: elastic#78832
💔 Backport failed
You can use sqren/backport to manually backport by running |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 5, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilge so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554, elastic#78832 Backport of: elastic#82046
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 5, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilege so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554 Relates: #78832
tvernum
added a commit
that referenced
this pull request
Jan 5, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilge so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554, #78832 Backport of: #82046
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilege so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554 Relates: elastic#78832
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
All three template types (legacy templates, composable index templates and component templates) are stored in cluster state metadata (in fields "templates", "index_template" and "component_template"). This cluster state is readable (via GET /_cluster/state) for users who have the monitor privilege at the cluster level. However, calling the explicit read endpoints for these templates required the manage_index_templates privilege. This change grants access to the template specific retrieval APIs for all users (or API Keys) with the cluster monitor privilege so that they can make use of these fit-for-purpose APIs instead of parsing data directly from cluster metadata Relates: elastic/beats#29554 Relates: elastic#78832
albertzaharovits
removed
the
:Data Management/Indices APIs
elasticmachine
removed
the
Team:Data Management
albertzaharovits
added
the
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
albertzaharovits
removed
the
:Data Management/Indices APIs
elasticmachine
removed
the
Team:Data Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three template types (legacy templates, composable index templates
and component templates) are stored in cluster state metadata
(in fields "templates", "index_template" and "component_template").
This cluster state is readable (via GET /_cluster/state) for users who
have the monitor privilege at the cluster level. However, calling the
explicit read endpoints for these templates required the
manage_index_templates privilege.
This change grants access to the template specific retrieval APIs for
all users (or API Keys) with the cluster monitor privilege so that they
can make use of these fit-for-purpose APIs instead of parsing data
directly from cluster metadata
Relates: elastic/beats#29554
Relates: #78832