Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Report _preview warning in the face of pipeline failure. #81972

Merged

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Dec 21, 2021

This PR reports the pipeline failures (e.g.: script failures) encountered in _preview as header warnings.
This way, the Transform API user knows the failure reason just by looking at the _preview response, before they create an actual transform.

Fixes #81514

@przemekwitek przemekwitek force-pushed the transform_fix_null_preview branch 3 times, most recently from e1ef6e8 to 633a6b4 Compare December 21, 2021 10:27
@przemekwitek przemekwitek added v8.0.0 and removed WIP labels Dec 21, 2021
@przemekwitek przemekwitek marked this pull request as ready for review December 21, 2021 10:28
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Dec 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek force-pushed the transform_fix_null_preview branch from 633a6b4 to ea634f1 Compare January 4, 2022 09:45
@benwtrent benwtrent self-requested a review January 4, 2022 12:33
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 81972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] Preview transform returns 'null' when ingest pipeline throws an exception
5 participants