Add delete privilege to kibana_system for APM and Endpoint ILM policies #81811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
elasticsearchmachine
added
the
external-contributor
joshdover
commented
Dec 16, 2021
Comment on lines
796
to
797
| assertThat(kibanaRole.indices().allowedIndicesMatcher(UpdateSettingsAction.NAME).test(indexAbstraction), is(true)); | ||
| assertThat(kibanaRole.indices().allowedIndicesMatcher(RolloverAction.NAME).test(indexAbstraction), is(true)); |
There was a problem hiding this comment.
These are already granted by the overall wider privileges for metrics-* and traces-*, but I added an explicit test to ensure we meet the ILM requirements
ywangd
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
LGTM and please address my comments before merging.
v7.17.0 is not in the PR's labels. But I assume you would want it as well. The 7.17 branch is already cut. So the backport must be a separate one from 7.16.
Also, I agree with your analysis on the Kibana issue. This approach is too much overhead for taking in new packages. It definitely won't scale for 3rd party ones. I am ok with the short term solution. But we ought to work on the long term solution before there are too many packages.
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
joshdover
added a commit
to joshdover/elasticsearch
that referenced
this pull request
Dec 17, 2021
joshdover
added a commit
to joshdover/elasticsearch
that referenced
this pull request
Dec 17, 2021
joshdover
added a commit
to joshdover/elasticsearch
that referenced
this pull request
Dec 17, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2022
…es (#81811) (#81873) Co-authored-by: Elastic Machine <[email protected]>
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/kibana#121244
Adds the necessary delete index privilege required to execute the ILM policies for a subset of APM and Endpoint data streams. Examples of the ILM policies that we need to support: