-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UnboundID LDAP SDK to 6.0.3 #81568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new release contains fixes for leaking threads (see elastic#80305) and bias in round robin server sets, both of which are relevant to Elasticsearch security. Resolves: elastic#80305
tvernum
added
>non-issue
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
v8.0.0
auto-backport-and-merge
v8.1.0
labels
Dec 9, 2021
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we want to remove this special handling for 6.0.2?
Lines 203 to 211 in 647e5fe
if (com.unboundid.ldap.sdk.Version.getShortVersionString().equals("unboundid-ldapsdk-6.0.2")) { | |
// This is the behaviour in 6.0.2, but per it should be fixed in 6.0.3 | |
// See: https://github.com/pingidentity/ldapsdk/issues/118 | |
// See: https://github.com/pingidentity/ldapsdk/commit/2d08c5258c3a62b7c90cd4e878c4a0d25ae01a82 | |
ports.forEach(port -> { | |
int count = bindCountPerPort.get(port).get(); | |
assertThat("Connections to port [" + port + "]", count, greaterThanOrEqualTo(numberOfIterations)); | |
assertThat("Connections to port [" + port + "]", count, lessThanOrEqualTo(numberOfIterations * (1 + numberToKill))); | |
}); |
💚 Backport successful
|
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Dec 9, 2021
The new release contains fixes for leaking threads (see elastic#80305) and bias in round robin server sets, both of which are relevant to Elasticsearch security. Resolves: elastic#80305
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2021
The new release contains fixes for leaking threads (see #80305) and bias in round robin server sets, both of which are relevant to Elasticsearch security. Resolves: #80305 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>non-issue
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
v8.0.0-rc2
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release contains fixes for leaking threads (see #80305) and
bias in round robin server sets, both of which are relevant to
Elasticsearch security.
Resolves: #80305