Add an assert to detect double decrementing of ingest metrics #81450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and assert at dev-time if we try to make it go negative.
joegallo
added
WIP
:Data Management/Stats
If we trigger this during a test, we'll fail loudly at test time (rather than requiring a subsequent cluster stats call to see that there's an issue).
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
changed the title
This comment has been minimized.
This comment has been minimized.
joegallo
added a commit
that referenced
this pull request
Dec 7, 2021
joegallo
added a commit
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #77973
This doesn't change the underlying cause of #77973 (something is double decrementing, or so the theory goes), nor does it paper over that bug at the serialization layer. However, if we ever have a test that triggers double decrementing, it will now fail loudly rather than requiring a subsequent cluster stats call in order to call attention to the issue.
It's not ideal, but it's not nothing, either.