Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[8.0] [ML] Ensure BertTokenizer does not split special toke… #81422

Conversation

dimitris-athanasiou
Copy link
Contributor

…ns (#81254) (#81371)"

This reverts commit 9fc8415.

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Dec 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dimitris-athanasiou
Copy link
Contributor Author

This reverts #81371 as it is too large a change to backport to 8.0.0.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou dimitris-athanasiou merged commit 504b86c into elastic:8.0 Dec 7, 2021
@dimitris-athanasiou dimitris-athanasiou deleted the revert-token-trie-for-bert-tokenization branch December 7, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.0.0-rc2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants