Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Remove source query params from update/delete by query APIs #81131

Merged
merged 1 commit into from
Dec 1, 2021
Merged

[DOCS] Remove source query params from update/delete by query APIs #81131

merged 1 commit into from
Dec 1, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Nov 29, 2021 •
edited
Loading

Removes source-related query parameters from the update by query
and delete by query API documentation. These parameters don't return
source fields as part of the response.

Closes #80962

@jrodewig
[DOCS] Remove source query params from update/delete by query APIs
c0db1ca 
Removes source-related query parameters from the update by query
and delete by query API documentation. These parameters don't return
source fields as part of the response.
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Nov 29, 2021
@jrodewig jrodewig added v7.15.3 v7.16.1 v8.0.0 :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Nov 29, 2021
@jrodewig jrodewig marked this pull request as ready for review November 29, 2021 22:38
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@jrodewig jrodewig requested a review from DaveCTurner November 29, 2021 22:38
@jrodewig jrodewig added the >docs General docs changes label Nov 29, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Nov 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

sethmlarson
sethmlarson approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good from a spec perspective.

@jrodewig jrodewig requested a review from jportner November 30, 2021 23:08
jportner
jportner approved these changes Dec 1, 2021
View reviewed changes
Copy link

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@jrodewig jrodewig merged commit ca8c9be into elastic:master Dec 1, 2021
@jrodewig jrodewig deleted the docs__remove-source-params branch December 1, 2021 14:06
This was referenced Dec 1, 2021
Merged
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
@jrodewig
[DOCS] Remove source query params from update/delete by query APIs (#…
28c8b1a 
…81131) (#81209)

Removes source-related query parameters from the update by query
and delete by query API documentation. These parameters don't return
source fields as part of the response.
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
@jrodewig
[DOCS] Remove source query params from update/delete by query APIs (#…
879a765 
…81131) (#81213)

Removes source-related query parameters from the update by query
and delete by query API documentation. These parameters don't return
source fields as part of the response.
# Conflicts:
#	rest-api-spec/src/main/resources/rest-api-spec/api/delete_by_query.json
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
@jrodewig
[DOCS] Remove source query params from update/delete by query APIs (#…
762e537 
…81131) (#81212)

Removes source-related query parameters from the update by query
and delete by query API documentation. These parameters don't return
source fields as part of the response.
# Conflicts:
#	rest-api-spec/src/main/resources/rest-api-spec/api/delete_by_query.json
@sethmlarson sethmlarson mentioned this pull request Dec 1, 2021
Merged
@danhermann danhermann added v7.16.0 and removed v7.16.1 labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@jportner jportner jportner approved these changes

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes Team:Clients Meta label for clients team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.15.3 v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] _source* params don't work for Update by query / Delete by query
7 participants
@jrodewig @elasticmachine @jportner @sethmlarson @mark-vieira @danhermann @elasticsearchmachine