Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDB: fix error without feature flag #80945

Merged
merged 1 commit into from
Nov 23, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TSDB: fix error without feature flag
When you haven't enable the tsdb feature flag we would refuse to start.
That's bad because we will likely release with the feature flag
disabled. This should get us starting again. It fixes:

* We tried to register a settings update consumer for the `end_time` for
  the tsdb index even when the `end_time` setting wasn't registered.
* Pass the tsdb feature flag to internal cluster tests.
nik9000 committed Nov 23, 2021
commit 0a3d64f59785182681a62836f33cd9df2e84db05
3 changes: 3 additions & 0 deletions server/build.gradle
Original file line number Diff line number Diff line change
@@ -132,6 +132,9 @@ if (BuildParams.isSnapshotBuild() == false) {
tasks.named("test").configure {
systemProperty 'es.index_mode_feature_flag_registered', 'true'
}
tasks.named("internalClusterTest").configure {
systemProperty 'es.index_mode_feature_flag_registered', 'true'
}
}

tasks.named("thirdPartyAudit").configure {
Original file line number Diff line number Diff line change
@@ -813,7 +813,9 @@ public IndexSettings(final IndexMetadata indexMetadata, final Settings nodeSetti
scopedSettings.addSettingsUpdateConsumer(INDEX_MAPPING_DEPTH_LIMIT_SETTING, this::setMappingDepthLimit);
scopedSettings.addSettingsUpdateConsumer(INDEX_MAPPING_FIELD_NAME_LENGTH_LIMIT_SETTING, this::setMappingFieldNameLengthLimit);
scopedSettings.addSettingsUpdateConsumer(INDEX_MAPPING_DIMENSION_FIELDS_LIMIT_SETTING, this::setMappingDimensionFieldsLimit);
scopedSettings.addSettingsUpdateConsumer(TIME_SERIES_END_TIME, this::updateTimeSeriesEndTime);
if (IndexSettings.isTimeSeriesModeEnabled()) {
scopedSettings.addSettingsUpdateConsumer(TIME_SERIES_END_TIME, this::updateTimeSeriesEndTime);
}
}

private void setSearchIdleAfter(TimeValue searchIdleAfter) {