Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TracingPlugin interface #80799

Conversation

DaveCTurner
Copy link
Contributor

No description provided.

@DaveCTurner DaveCTurner requested a review from gwbrown November 17, 2021 16:28
@DaveCTurner
Copy link
Contributor Author

Turns out we're not really using this, so let's drop it.

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -6,23 +6,14 @@
* Side Public License, v 1.
*/

package org.elasticsearch.plugins;
package org.elasticsearch.tasks;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to make a dedicated package for tracing (as cluster state and auth tracing is not directly related to tasks)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ moved to org.elasticsearch.tracing in f73b052.

@DaveCTurner DaveCTurner added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement labels Nov 18, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 18, 2021
@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 18, 2021
@DaveCTurner DaveCTurner merged commit 3a304f2 into elastic:feature/apm-integration Nov 18, 2021
@DaveCTurner DaveCTurner deleted the 2021-11-17-unused-tracingplugin branch November 18, 2021 11:24
@tlrx
Copy link
Member

tlrx commented Nov 19, 2021

I come late to the party but LGTM - This is a good change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants