Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OpenTelemetry with HTTP/gRPC exporters in apm-integration #80762

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Use OpenTelemetry with HTTP/gRPC exporters in apm-integration #80762

merged 3 commits into from
Nov 17, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Nov 16, 2021

This pull request adds support for HTPP/gRPC with the OpenTelemetry SDK in the apm-integration plugin. It adds the required security permissions to the plugin to make it work - we should try to reduce this list one day.

The plumbing to pass Elastic's Cloud APM server credentials is not fully there yet but the current ApmIT test can be executed with -Dtests.apm.endpoint=https://... -Dtests.apm.token=ABC and traces should be sent to Elastic APM.

Works on my machine™

@tlrx tlrx added >enhancement :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. labels Nov 16, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

gwbrown
gwbrown approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being at all familiar with the OpenTelemetry API, but having reviewed all the relevant PRs up until this point: LGTM.

ywangd
ywangd approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just need two more security permissions for allowing exporting data to a Cloud APM server.
I can also confirm the ApmIT teset run successful on my machine.

x-pack/plugin/apm-integration/src/main/plugin-metadata/plugin-security.policy Show resolved Hide resolved
@tlrx @ywangd
Update x-pack/plugin/apm-integration/src/main/plugin-metadata/plugin-…
9e084fc 
…security.policy


add permissions

Co-authored-by: Yang Wang <[email protected]>
@tlrx tlrx added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 17, 2021
@elasticsearchmachine elasticsearchmachine merged commit d5a2503 into elastic:feature/apm-integration Nov 17, 2021
@tlrx tlrx deleted the use-http-grpc-with-apm branch November 17, 2021 09:33
@tlrx
Copy link
Member Author

tlrx commented Nov 17, 2021

Thanks everyone!

DaveCTurner
DaveCTurner reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, I was having too much fun playing around with it. LGTM2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner left review comments

@ywangd ywangd ywangd approved these changes

@gwbrown gwbrown gwbrown approved these changes

@SylvainJuge SylvainJuge SylvainJuge approved these changes

@dimitris-athanasiou dimitris-athanasiou Awaiting requested review from dimitris-athanasiou

@idegtiarenko idegtiarenko Awaiting requested review from idegtiarenko

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tlrx @elasticmachine @SylvainJuge @gwbrown @ywangd @DaveCTurner @elasticsearchmachine