-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DockerTests.test022InstallPlugin assertion #80741
Merged
elasticsearchmachine
merged 2 commits into
elastic:master
from
mark-vieira:fix_dockertests_assertion
Nov 15, 2021
Merged
Fix DockerTests.test022InstallPlugin assertion #80741
elasticsearchmachine
merged 2 commits into
elastic:master
from
mark-vieira:fix_dockertests_assertion
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
Issues or PRs that are addressing/adding tests
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
labels
Nov 15, 2021
Pinging @elastic/es-delivery (Team:Delivery) |
Nevermind, I see the backports have been merged. |
@elasticmachine run elasticsearch-ci/docs |
@elasticmachine run elasticsearch-ci/packaging-upgrade-tests |
pugnascotia
approved these changes
Nov 15, 2021
💔 Backport failed
You can use sqren/backport to manually backport by running |
pugnascotia
pushed a commit
that referenced
this pull request
Nov 16, 2021
Use order agnostic assertion when testing plugin installation. https://gradle-enterprise.elastic.co/s/57wwszvhfzwnw/tests/:qa:os:destructiveDistroTest.default-dockerCloud/org.elasticsearch.packaging.test.DockerTests/test022InstallPlugin @pugnascotia This will likely need to be included in your backport of #80734
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 16, 2021
Use order agnostic assertion when testing plugin installation. https://gradle-enterprise.elastic.co/s/57wwszvhfzwnw/tests/:qa:os:destructiveDistroTest.default-dockerCloud/org.elasticsearch.packaging.test.DockerTests/test022InstallPlugin @pugnascotia This will likely need to be included in your backport of elastic#80734 # Conflicts: # qa/os/src/test/java/org/elasticsearch/packaging/test/DockerTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Fix DockerTests.test022InstallPlugin assertion (#80741) Use order agnostic assertion when testing plugin installation. https://gradle-enterprise.elastic.co/s/57wwszvhfzwnw/tests/:qa:os:destructiveDistroTest.default-dockerCloud/org.elasticsearch.packaging.test.DockerTests/test022InstallPlugin @pugnascotia This will likely need to be included in your backport of #80734 # Conflicts: # qa/os/src/test/java/org/elasticsearch/packaging/test/DockerTests.java * Fix compiler error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
Team:Delivery
Meta label for Delivery team
>test
Issues or PRs that are addressing/adding tests
v7.16.0
v8.0.0-rc1
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use order agnostic assertion when testing plugin installation.
https://gradle-enterprise.elastic.co/s/57wwszvhfzwnw/tests/:qa:os:destructiveDistroTest.default-dockerCloud/org.elasticsearch.packaging.test.DockerTests/test022InstallPlugin
@pugnascotia This will likely need to be included in your backport of #80734